linux-kernel - Re: [PATCH -next] staging: rtl8712: drop pointless static qualifier in r8712_efuse_pg_packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfb52a90-554c-a144-b928-eb787831ccd0@lwfinger.net>
Date:   Mon, 21 Jan 2019 11:56:10 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     YueHaibing <yuehaibing@...wei.com>,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] staging: rtl8712: drop pointless static qualifier
 in r8712_efuse_pg_packet_write()

On 1/21/19 1:53 AM, YueHaibing wrote:
> There is no need to have the 'intrepeat_times' variable static since new
> value always be assigned before use it.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/staging/rtl8712/rtl8712_efuse.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
> index 8bc45ff..39eb743 100644
> --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> @@ -358,7 +358,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
>   	u8 pg_header = 0;
>   	u16 efuse_addr = 0, curr_size = 0;
>   	u8 efuse_data, target_word_cnts = 0;
> -	static int repeat_times;
> +	int repeat_times;
>   	int sub_repeat;
>   	u8 bResult = true;

Clearly, the value of this variable is not intended to be carried over between 
calls to this routine. Your fix is correct.

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks,

Larry