linux-kernel - Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Jan 2019 18:30:54 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Curtis Malainey <cujomalainey@...gle.com>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Matthias Reichl <hias@...us.com>, rohkumar@....qualcomm.com,
        alsa-devel@...a-project.org, bgoswami@...eaurora.org,
        vinod.koul@...aro.org, lgirdwood@...il.com, plai@...eaurora.org,
        linux-kernel@...r.kernel.org, tiwai@...e.com,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        srinivas.kandagatla@...aro.org,
        Rohit kumar <rohitkr@...eaurora.org>, asishb@...eaurora.org,
        Ajit Pandey <ajitp@...eaurora.org>,
        Curtis Malainey <cujomalainey@...omium.org>,
        Dylan Reid <dgreid@...gle.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer
 dereference in soc_find_component

On Fri, Jan 18, 2019 at 05:15:32PM -0800, Curtis Malainey wrote:

> of_node was never getting set but the pointer was becoming populated
> (outside of the probe call) which traced to soc_init_platform function
> which was not reallocating memory on a EPROBE_DEFER even though it was
> getting freed by devm. I am not very familiar with devm but my local
> maintainers say that it should be freeing the memory even on a
> PROBE_DEFER.

Probe deferral is just like any other error from probe, any managed
resources will be unwound.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)