linux-kernel - Re: [PATCH 1/2] hwmon (occ): Fix license headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0566a8cf-b9f3-617a-712e-95c92cf8af70@linux.ibm.com>
Date:   Mon, 21 Jan 2019 15:15:29 -0600
From:   Eddie James <eajames@...ux.ibm.com>
To:     Joel Stanley <joel@....id.au>
Cc:     linux-hwmon@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] hwmon (occ): Fix license headers



On 01/21/2019 02:19 PM, Joel Stanley wrote:
> On Tue, 22 Jan 2019 at 06:56, Eddie James <eajames@...ux.ibm.com> wrote:
>
>> --- a/drivers/hwmon/occ/common.h
>> +++ b/drivers/hwmon/occ/common.h
>> @@ -1,4 +1,5 @@
>> -/* SPDX-License-Identifier: GPL-2.0 */
>> +// SPDX-License-Identifier: GPL-2.0+
>> +// Copyright IBM Corp 2019
> We want to use the /* */ syntax for headers. Take a closer look at
> Documentation/process/license-rules.rst:

Oops. Do I put the copyright in the copyright in the same comment block 
then? Or use // for that?

>
> 2. Style:
>
>     The SPDX license identifier is added in form of a comment.  The comment
>     style depends on the file type::
>
>        C source: // SPDX-License-Identifier: <SPDX License Expression>
>        C header: /* SPDX-License-Identifier: <SPDX License Expression> */
>