[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190120214448.yjiuy7gqkfcrktss@earth.universe>
Date: Sun, 20 Jan 2019 22:44:48 +0100
From: Sebastian Reichel <sre@...nel.org>
To: fuyao <fuyao@...winnertech.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power_suuupy: change brace's place
Hi fuyao,
Sorry, but your patch does not follow kernel patch submission rules.
All patches should have a long description, that describes _why_ the
patch is required. Also it needs a Signed-off-by line submitted with
your full realname. Last but not least there is a typo in the
subject and the patch is not send to the right mailinglist. Please
resubmit after reading the files in Documentation/process.
Thanks for your patch,
-- Sebastian
On Sat, Dec 29, 2018 at 01:59:25PM +0800, fuyao wrote:
> ---
> drivers/power/supply/power_supply_sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index 5204f115970f..be1577e96c59 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -75,7 +75,8 @@ static const char * const power_supply_scope_text[] = {
>
> static ssize_t power_supply_show_property(struct device *dev,
> struct device_attribute *attr,
> - char *buf) {
> + char *buf)
> +{
> ssize_t ret = 0;
> struct power_supply *psy = dev_get_drvdata(dev);
> const ptrdiff_t off = attr - power_supply_attrs;
> --
> 2.19.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists