linux-kernel - Re: [PATCH -next] drm/stm: ltdc: remove set but not used variable 'src

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Jan 2019 10:09:39 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Yannick Fertre <yannick.fertre@...com>,
        Philippe Cornu <philippe.cornu@...com>,
        Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-stm32@...md-mailman.stormreply.com,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] drm/stm: ltdc: remove set but not used variable 'src_h'

Le lun. 21 janv. 2019 à 09:21, YueHaibing <yuehaibing@...wei.com> a écrit :
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/stm/ltdc.c: In function 'ltdc_plane_atomic_check':
> drivers/gpu/drm/stm/ltdc.c:694:13: warning:
>  variable 'src_y' set but not used [-Wunused-but-set-variable]
>   u32 src_x, src_y, src_w, src_h;
>              ^
>              ^
> drivers/gpu/drm/stm/ltdc.c:694:6: warning:
>  variable 'src_x' set but not used [-Wunused-but-set-variable]
>   u32 src_x, src_y, src_w, src_h;
>       ^
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied on drm-misc-next,

Thanks,
Benjamin

> ---
>  drivers/gpu/drm/stm/ltdc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 61dd661..a91e041 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -691,7 +691,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
>                                    struct drm_plane_state *state)
>  {
>         struct drm_framebuffer *fb = state->fb;
> -       u32 src_x, src_y, src_w, src_h;
> +       u32 src_w, src_h;
>
>         DRM_DEBUG_DRIVER("\n");
>
> @@ -699,8 +699,6 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
>                 return 0;
>
>         /* convert src_ from 16:16 format */
> -       src_x = state->src_x >> 16;
> -       src_y = state->src_y >> 16;
>         src_w = state->src_w >> 16;
>         src_h = state->src_h >> 16;
>
>
>
>
>
>