linux-kernel - Re: [PATCH v2] dio: Fix buffer overflow in case of unknown board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXJcOQ2NMoHbAvqfP5YbSRA1Xt_MWpnyKe18t-ZAyVY1Q@mail.gmail.com>
Date:   Mon, 21 Jan 2019 10:43:57 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Kars de Jong <jongk@...ux-m68k.org>
Cc:     linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] dio: Fix buffer overflow in case of unknown board

On Mon, Jan 21, 2019 at 10:24 AM Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> With gcc 8.2.0:
>
>     drivers/dio/dio.c: In function ‘dio_init’:
>     drivers/dio/dio.c:240:17: warning: ‘strcpy’ writing 69 or more bytes into a region of size 64 overflows the destination [-Wstringop-overflow=]
>                      strcpy(dev->name,dio_getname(dev->id));
>                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Indeed, if an unknown board is present, the target buffer will overflow.
> Shorten the unknown board name string to fix this, and declare it as an
> array while at it.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks, applied and queued for v5.1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds