lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Jan 2019 10:56:46 +0100 From: Marek Szyprowski <m.szyprowski@...sung.com> To: Alexey Khoroshilov <khoroshilov@...ras.ru>, Felipe Balbi <balbi@...nel.org> Cc: Kukjin Kim <kgene@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org Subject: Re: [PATCH] usb: dwc3: exynos: Fix error handling of clk_prepare_enable Hi Alexey, On 2019-01-18 22:17, Alexey Khoroshilov wrote: > If clk_prepare_enable() fails in dwc3_exynos_probe(), > exynos->clks[0] is left undisabled because of usage > preincrement in while condition. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru> > Fixes: 9f2168367a0a ("usb: dwc3: exynos: Rework clock handling and prepare for new variants") My fault. There is also a similar issue dwc3_exynos_resume(), so please fix it too if possible. > --- > drivers/usb/dwc3/dwc3-exynos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c > index cb7fcd7c0ad8..e7f6cff27b9a 100644 > --- a/drivers/usb/dwc3/dwc3-exynos.c > +++ b/drivers/usb/dwc3/dwc3-exynos.c > @@ -78,7 +78,7 @@ static int dwc3_exynos_probe(struct platform_device *pdev) > for (i = 0; i < exynos->num_clks; i++) { > ret = clk_prepare_enable(exynos->clks[i]); > if (ret) { > - while (--i > 0) > + while (i-- > 0) > clk_disable_unprepare(exynos->clks[i]); > return ret; > } Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
Powered by blists - more mailing lists