linux-kernel - Re: [PATCH V9 3/3] mmc: tegra: HW Command Queue Support for Tegra SDMMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44e837df-f1c1-b55c-3761-ef699147171f@intel.com>
Date:   Mon, 21 Jan 2019 14:52:59 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Sowjanya Komatineni <skomatineni@...dia.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, mperttunen@...dia.com,
        chunyan.zhang@...soc.com, jonathanh@...dia.com,
        ulf.hansson@...aro.org, anrao@...dia.com,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH V9 3/3] mmc: tegra: HW Command Queue Support for Tegra
 SDMMC

On 21/01/19 12:44 PM, Thierry Reding wrote:
> On Tue, Jan 15, 2019 at 11:03:52AM -0800, Sowjanya Komatineni wrote:
>> This patch adds HW Command Queue for supported Tegra SDMMC
>> controllers.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@...dia.com>
>> ---
>>  drivers/mmc/host/Kconfig       |   1 +
>>  drivers/mmc/host/sdhci-tegra.c | 117 +++++++++++++++++++++++++++++++++++++++--
>>  drivers/mmc/host/sdhci.c       |   9 +++-
>>  drivers/mmc/host/sdhci.h       |   2 +
>>  4 files changed, 124 insertions(+), 5 deletions(-)
> 
> Looks good to me. It might be worth splitting off the SDHCI core changes
> into a separate patch, but that's for Adrian and Ulf to decide. From a

Yes that would be better.  Otherwise seems fine.

> Tegra point of view:
> 
> Acked-by: Thierry Reding <treding@...dia.com>
>