linux-kernel - Re: [PATCH 1/2] gpio: pca953x: reduce indentation level in pca953x_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaN=kjgP7wgcOTfxuu_BM_ggADhKtesf4qEhx3aNhS4_Q@mail.gmail.com>
Date:   Mon, 21 Jan 2019 14:05:13 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Marek Vasut <marex@...x.de>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Subject: Re: [PATCH 1/2] gpio: pca953x: reduce indentation level in pca953x_irq_setup()

On Wed, Jan 16, 2019 at 10:32 AM Thomas Petazzoni
<thomas.petazzoni@...tlin.com> wrote:

> The current design of pca953x_irq_setup() is:
>
>  if (all conditions to support IRQ are met) {
>    lots of code to support IRQs, which goes to a serious indentation
>    level.
>  }
>
>  return 0;
>
> It makes more sense to handle this like this:
>
>  if (!all conditions to support IRQ are met)
>    return 0;
>
>  handle IRQ support
>
> This commit does just this change, reducing by one tab the indentation
> level of the IRQ setup code. Thanks to this reduced indentation level,
> we are less restricted by the 80-column limit, and we can have more
> function arguments on the same line.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...tlin.com>

Patch applied.

Yours,
Linus Walleij