linux-kernel - Re: [PATCH] tty: serial: lpc32xx_hs: fix missing console boot messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e7fb8d2d-5daf-afdf-bd8e-472c76701650@mleia.com>
Date:   Wed, 23 Jan 2019 00:38:50 +0200
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Roland Stigge <stigge@...com.de>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        Jiri Slaby <jslaby@...e.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] tty: serial: lpc32xx_hs: fix missing console boot
 messages

Hi Alexandre,

On 01/15/2019 07:18 PM, Alexandre Belloni wrote:
> When probing the HSUART, it is put in loopback mode in order to prevent a
> potential issue that may happen on RX (Errata HSUART.1).
> 
> serial_lpc32xx_startup() moves it out of loopback mode but this is too late
> to get the kernel boot messages before userspace opens the device.
> 
> Also get out of loopback mode in lpc32xx_hsuart_console_setup().
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

the change looks good, thank you.

Acked-by: Vladimir Zapolskiy <vz@...ia.com>

--
Best wishes,
Vladimir