linux-kernel - Re: [PATCH] Bluetooth: hci_uart: Check if socket buffer is ERR_PTR in h4_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <F686949E-7FDE-4AE1-8021-CA024E89A9A0@holtmann.org>
Date:   Tue, 22 Jan 2019 09:49:15 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Myungho Jung <mhjungk@...il.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_uart: Check if socket buffer is ERR_PTR in
 h4_recv_buf()

Hi Myungho,

> h4_recv_buf() callers store the return value to socket buffer and
> recursively pass the buffer to h4_recv_buf() without protection. So,
> ERR_PTR returned from h4_recv_buf() can be dereferenced, if called again
> before setting the socket buffer to NULL from previous error. Check if
> skb is ERR_PTR in h4_recv_buf().
> 
> Reported-by: syzbot+017a32f149406df32703@...kaller.appspotmail.com
> Signed-off-by: Myungho Jung <mhjungk@...il.com>
> ---
> drivers/bluetooth/h4_recv.h | 4 ++++
> drivers/bluetooth/hci_h4.c  | 4 ++++
> 2 files changed, 8 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel