lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Jan 2019 10:24:39 +0100 From: <gregkh@...uxfoundation.org> To: andrew.smirnov@...il.com, akpm@...ux-foundation.org, cphealy@...il.com, dwmw2@...radead.org, gregkh@...uxfoundation.org, kyle@...nel.org, linux-kernel@...r.kernel.org, yamada.masahiro@...ionext.com Subject: patch "ihex: Check if zero-length record is at the end of the blob" added to driver-core-testing This is a note to let you know that I've just added the patch titled ihex: Check if zero-length record is at the end of the blob to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-testing branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will be merged to the driver-core-next branch sometime soon, after it passes testing, and the merge window is open. If you have any questions about this process, please let me know. >From 5158c36ec9d0b3343f58987cec7ebfd866331fd0 Mon Sep 17 00:00:00 2001 From: Andrey Smirnov <andrew.smirnov@...il.com> Date: Thu, 20 Dec 2018 23:28:38 -0800 Subject: ihex: Check if zero-length record is at the end of the blob When verifying the validity of IHEX file we need to make sure that zero-length record we found is located at the end of the file. Not doing that could result in an invalid file with a bogus zero-length in the middle short-circuiting the check and being reported as valid. Cc: Chris Healy <cphealy@...il.com> Cc: Kyle McMartin <kyle@...nel.org> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com> Cc: David Woodhouse <dwmw2@...radead.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: linux-kernel <linux-kernel@...r.kernel.org> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- include/linux/ihex.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/ihex.h b/include/linux/ihex.h index 9c701521176b..9130f307a420 100644 --- a/include/linux/ihex.h +++ b/include/linux/ihex.h @@ -49,7 +49,7 @@ static inline int ihex_validate_fw(const struct firmware *fw) for (; rec <= end; rec = __ihex_next_binrec(rec)) { /* Zero length marks end of records */ - if (!be16_to_cpu(rec->len)) + if (rec == end && !be16_to_cpu(rec->len)) return 0; } return -EINVAL; -- 2.20.1
Powered by blists - more mailing lists