linux-kernel - Re: [PATCH V3] cacheinfo: Keep the old value if of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f1a742c-9123-e615-6abc-bc6325a7644c@arm.com>
Date:   Tue, 22 Jan 2019 10:30:42 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     chenhuacai@...il.com, gregkh@...uxfoundation.org
Cc:     Sudeep.Holla@....com, rafael@...nel.org,
        linux-kernel@...r.kernel.org, zhangfx@...ote.com,
        wuzhangjin@...il.com, stable@...r.kernel.org
Subject: Re: [PATCH V3] cacheinfo: Keep the old value if of_property_read_u32
 fails


On 22/01/2019 00:51, Huacai Chen wrote:
> Ping?
> 
> On Wed, Dec 19, 2018 at 4:15 PM Huacai Chen <chenhc@...ote.com> wrote:
>>
>> Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF
>> property_read_u32 instead of get_property,read_number") makes cache
>> size and number_of_sets be 0 if DT doesn't provide there values. I
>> think this is unreasonable so make them keep the old values, which is
>> the same as old kernels.
>>
>> Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number")
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Huacai Chen <chenhc@...ote.com>
>> Reviewed-by: Sudeep Holla <sudeep.holla@....com>

Looks like this slipped through the cracks during holiday period.
Wait until Greg responds for a week, if not please repost as it may be
difficult to dig out old emails especially the ones during holidays.

-- 
Regards,
Sudeep