linux-kernel - Re: [PATCH v2] tty: moxa: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dd89334-8703-760d-4295-e626cc65ea19@suse.cz>
Date:   Tue, 22 Jan 2019 12:16:35 +0100
From:   Jiri Slaby <jslaby@...e.cz>
To:     Antoine Robertson <antoinerbrtsn@...il.com>,
        gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tty: moxa: Fix coding style issues

On 21. 01. 19, 23:45, Antoine Robertson wrote:
> Fix coding style issues
> 
> Signed-off-by: Antoine Robertson <antoinerbrtsn@...il.com>
> ---
>  drivers/tty/moxa.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index 3a1a5e0ee93f..9b6dcb4f7905 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
...
> @@ -1159,9 +1158,8 @@ static int moxa_open(struct tty_struct *tty, struct file *filp)
>  	int port;
>  
>  	port = tty->index;
> -	if (port == MAX_PORTS) {
> +	if (port == MAX_PORTS)
>  		return capable(CAP_SYS_ADMIN) ? 0 : -EPERM;
> -	}

Put a newline instead here, please.

>  	if (mutex_lock_interruptible(&moxa_openlock))
>  		return -ERESTARTSYS;
>  	brd = &moxa_boards[port / MAX_PORTS_PER_BOARD];
-- 
js
suse labs