lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 23 Jan 2019 06:45:37 +0800
From:   Liu Jian <liujian56@...wei.com>
To:     <gregkh@...uxfoundation.org>
CC:     <hamish.martin@...iedtelesis.co.nz>, <linux-kernel@...r.kernel.org>
Subject: [PATCH v2 1/2] driver: uio: fix possible memory leak in __uio_register_device

'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.

Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are
open")
Signed-off-by: Liu Jian <liujian56@...wei.com>
Reviewed-by: Hamish Martin <hamish.martin@...iedtelesis.co.nz>
---
 drivers/uio/uio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index b4ae2d9..4d20220 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -941,8 +941,10 @@ int __uio_register_device(struct module *owner,
 	atomic_set(&idev->event, 0);
 
 	ret = uio_get_minor(idev);
-	if (ret)
+	if (ret) {
+		kfree(idev);
 		return ret;
+	}
 
 	idev->dev.devt = MKDEV(uio_major, idev->minor);
 	idev->dev.class = &uio_class;
-- 
2.7.4

Powered by blists - more mailing lists