lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 22 Jan 2019 15:27:35 +0100
From:   Greg Kroah-Hartman <>
To:     Johannes Thumshirn <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>
Subject: [PATCH v2] SCSI: fcoe: convert to use BUS_ATTR_WO

We are trying to get rid of BUS_ATTR() and the usage of that in the fcoe
driver can be trivially converted to use BUS_ATTR_WO(), so use that

Cc: Johannes Thumshirn <>
Cc: "James E.J. Bottomley" <>
Cc: "Martin K. Petersen" <>
Signed-off-by: Greg Kroah-Hartman <>
v2: Made simpler with wrapper functions to call the "real" show/store
    functions, thanks to James for the idea.
    Removed the EXPORT_SYMBOL() removal line, that belongs in a separate

 drivers/scsi/fcoe/fcoe_sysfs.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fcoe_sysfs.c
index 5c8310bade61..c3dcbdc3aa64 100644
--- a/drivers/scsi/fcoe/fcoe_sysfs.c
+++ b/drivers/scsi/fcoe/fcoe_sysfs.c
@@ -671,8 +671,19 @@ static const struct device_type fcoe_fcf_device_type = {
 	.release = fcoe_fcf_device_release,
-static BUS_ATTR(ctlr_create, S_IWUSR, NULL, fcoe_ctlr_create_store);
-static BUS_ATTR(ctlr_destroy, S_IWUSR, NULL, fcoe_ctlr_destroy_store);
+static ssize_t ctlr_create_store(struct bus_type *bus, const char *buf,
+				 size_t count)
+	return fcoe_ctlr_create_store(bus, buf, count);
+static BUS_ATTR_WO(ctlr_create);
+static ssize_t ctlr_destroy_store(struct bus_type *bus, const char *buf,
+				  size_t count)
+	return fcoe_ctlr_destroy_store(bus, buf, count);
+static BUS_ATTR_WO(ctlr_destroy);
 static struct attribute *fcoe_bus_attrs[] = {

Powered by blists - more mailing lists