lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Jan 2019 16:09:01 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: James Bottomley <jejb@...ux.ibm.com>, Martin Petersen <martin.petersen@...cle.com> Cc: linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Varun Prakash <varun@...lsio.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Johannes Thumshirn <jthumshirn@...e.de>, Oza Pawandeep <poza@...eaurora.org> Subject: [PATCH 2/7] scsi: csiostor: no need to check return value of debugfs_create functions When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@...cle.com> Cc: Varun Prakash <varun@...lsio.com> Cc: Bjorn Helgaas <bhelgaas@...gle.com> Cc: Johannes Thumshirn <jthumshirn@...e.de> Cc: Oza Pawandeep <poza@...eaurora.org> Cc: linux-scsi@...r.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/scsi/csiostor/csio_init.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c index cf629380a981..460e4ee1c8fe 100644 --- a/drivers/scsi/csiostor/csio_init.c +++ b/drivers/scsi/csiostor/csio_init.c @@ -167,14 +167,10 @@ csio_dfs_destroy(struct csio_hw *hw) * csio_dfs_init - Debug filesystem initialization for the module. * */ -static int +static void csio_dfs_init(void) { csio_debugfs_root = debugfs_create_dir(KBUILD_MODNAME, NULL); - if (!csio_debugfs_root) - pr_warn("Could not create debugfs entry, continuing\n"); - - return 0; } /* -- 2.20.1
Powered by blists - more mailing lists