lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 22 Jan 2019 17:48:51 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Ping-Ke Shih <pkshih@...ltek.com>,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH] realtek: no need to check return value of debugfs_create functions

Larry Finger <Larry.Finger@...inger.net> writes:

> On 1/22/19 9:21 AM, Greg Kroah-Hartman wrote:
>> When calling debugfs functions, there is no need to ever check the
>> return value.  The function can work or not, but the code logic should
>> never do something different based on this.
>>
>> Cc: Ping-Ke Shih <pkshih@...ltek.com>
>> Cc: Kalle Valo <kvalo@...eaurora.org>
>> Cc: linux-wireless@...r.kernel.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
> Greg,
>
> Please change the subject to read "rtlwifi: ...". Otherwise the patch is correct.

I can fix that during commit.

-- 
Kalle Valo

Powered by blists - more mailing lists