lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 22 Jan 2019 17:08:57 +0100
From:   Greg Kroah-Hartman <>
To:     Mark Brown <>
        "Rafael J. Wysocki" <>
Subject: Re: [PATCH] regmap: no need to check return value of debugfs_create

On Tue, Jan 22, 2019 at 03:56:06PM +0000, Mark Brown wrote:
> On Tue, Jan 22, 2019 at 04:21:06PM +0100, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> Given that all the rest of the function is doing is further debugfs
> operations and when it fails people trying to use the debugfs do welcome
> some diagnostics I'm not sure that's particularly helpful.

The only way it will fail is if we are out of memory.  And you are in a
bigger mess then, no one cares about debugfs calls, just make them and
move on, you should never care about the result of such a call.


greg k-h

Powered by blists - more mailing lists