linux-kernel - Re: [PATCH 1/8] infiniband: cxgb4: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbf27d3d-ff19-4054-9495-80bcb5a10485@opengridcomputing.com>
Date:   Tue, 22 Jan 2019 10:22:59 -0600
From:   Steve Wise <swise@...ngridcomputing.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>
Cc:     linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH 1/8] infiniband: cxgb4: no need to check return value of
 debugfs_create functions

Hey Greg,

On 1/22/2019 9:17 AM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Steve Wise <swise@...lsio.com>
> Cc: Doug Ledford <dledford@...hat.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: linux-rdma@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/infiniband/hw/cxgb4/device.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index c13c0ba30f63..9c10fff6dcfb 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -720,11 +720,8 @@ static const struct file_operations ep_debugfs_fops = {
>  	.read    = debugfs_read,
>  };
>  
> -static int setup_debugfs(struct c4iw_dev *devp)
> +static void setup_debugfs(struct c4iw_dev *devp)
>  {
> -	if (!devp->debugfs_root)
> -		return -1;
> -
>  	debugfs_create_file_size("qps", S_IWUSR, devp->debugfs_root,
>  				 (void *)devp, &qp_debugfs_fops, 4096);
>  
> @@ -740,7 +737,6 @@ static int setup_debugfs(struct c4iw_dev *devp)
>  	if (c4iw_wr_log)
>  		debugfs_create_file_size("wr_log", S_IWUSR, devp->debugfs_root,
>  					 (void *)devp, &wr_log_debugfs_fops, 4096);
> -	return 0;
>  }
>  
>  void c4iw_release_dev_ucontext(struct c4iw_rdev *rdev,
> @@ -1553,8 +1549,6 @@ static int __init c4iw_init_module(void)
>  		return err;
>  
>  	c4iw_debugfs_root = debugfs_create_dir(DRV_NAME, NULL);
> -	if (!c4iw_debugfs_root)
> -		pr_warn("could not create debugfs entry, continuing\n");
>  
>  	reg_workq = create_singlethread_workqueue("Register_iWARP_device");
>  	if (!reg_workq) {
> 

So it is not a problem to call debugfs_create_file_size() when
devp->debugfs_root is NULL?


Acked-by: Steve Wise <swise@...ngridcomputing.com>