linux-kernel - Re: [PATCH] regmap: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190122172246.GD7579@sirena.org.uk>
Date:   Tue, 22 Jan 2019 17:22:46 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] regmap: no need to check return value of debugfs_create
 functions

On Tue, Jan 22, 2019 at 05:43:52PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 22, 2019 at 04:38:26PM +0000, Mark Brown wrote:

> > No, it also fails if there's already something with the same name in
> > debugfs which can happen as as a result of configuration.  This gets
> > confusing for users, they see the debugfs files they're expecting but
> > the contents don't match up at all.

> How can you allow a duplicate name for the other regmap stuff?  Will
> that not also cause a collision somewhere else?

No, the only place we actually use the names for anything is when
creating the debugfs.  Otherwise the driver using the regmap deals with
a pointer to the regmap which doesn't have any collision risk.

> Anyway, if this is that big of a problem, ok, but then your code will
> run differently if debugfs is enabled or not, which isn't ok.  Don't
> rely on debugfs to do your name filtering for you :)

I'd rather hope that the debugfs creation code runs differently
depending on if debugfs is enabled, perhaps that's just a strange foible
of mine. :)

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)