linux-kernel - Re: [PATCH] mm: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190122172944.GL4087@dhcp22.suse.cz>
Date:   Tue, 22 Jan 2019 18:29:44 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        David Rientjes <rientjes@...gle.com>,
        Laura Abbott <labbott@...hat.com>, linux-mm@...ck.org
Subject: Re: [PATCH] mm: no need to check return value of debugfs_create
 functions

On Tue 22-01-19 17:27:49, Greg KH wrote:
> On Tue, Jan 22, 2019 at 05:07:01PM +0100, Michal Hocko wrote:
[...]
> > sounds like a poor design goal to me but not mine code to maintain so...
> 
> The design goal was to make it as simple as possible to use, and that
> includes "you do not care about the return value".  Now we do have to
> return a value because some people need that for when they want to make
> a subdirectory, or remove the file later on, otherwise I would have just
> had everything be a void return function :)

I suspect that you are making assumptions which might change in the
future and this whole mess will be unfixable. But whatever I do not care
about debugfs at all.
-- 
Michal Hocko
SUSE Labs