linux-kernel - Re: [PATCH 4/4] venus: helpers: drop setting of timestap invalid flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPBb6MWmeV2eUpk5HKOO1HVZ-eszehKfBW49+p4r-eSN1HuY0w@mail.gmail.com>
Date:   Wed, 23 Jan 2019 15:09:53 +0900
From:   Alexandre Courbot <acourbot@...omium.org>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>
Cc:     Linux Media Mailing List <linux-media@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org,
        Vikash Garodia <vgarodia@...eaurora.org>,
        Tomasz Figa <tfiga@...omium.org>,
        Malathi Gottam <mgottam@...eaurora.org>
Subject: Re: [PATCH 4/4] venus: helpers: drop setting of timestap invalid flag

On Wed, Jan 9, 2019 at 5:46 PM Stanimir Varbanov
<stanimir.varbanov@...aro.org> wrote:
>
> The zero timestap is really a valid so not sure why I discarded it. Fix

s/timestap/timestamp, also in patch title.

> that mistake by drop the code which checks for zero timestamp.

s/drop/dropping


>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>
> ---
>  drivers/media/platform/qcom/venus/helpers.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index e436385bc5ab..5cad601d4c57 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -439,9 +439,6 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf)
>         fdata.flags = 0;
>         fdata.clnt_data = vbuf->vb2_buf.index;
>
> -       if (!fdata.timestamp)
> -               fdata.flags |= HFI_BUFFERFLAG_TIMESTAMPINVALID;
> -
>         if (type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
>                 fdata.buffer_type = HFI_BUFFER_INPUT;
>                 fdata.filled_len = vb2_get_plane_payload(vb, 0);
> --
> 2.17.1
>