linux-kernel - Re: [PATCH] block: aoe: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Jan 2019 07:41:18 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Omar Sandoval <osandov@...ndov.com>
Cc:     linux-kernel@...r.kernel.org, "Ed L. Cashin" <ed.cashin@....org>,
        Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org
Subject: Re: [PATCH] block: aoe: no need to check return value of
 debugfs_create functions

On Tue, Jan 22, 2019 at 03:29:33PM -0800, Omar Sandoval wrote:
> On Tue, Jan 22, 2019 at 04:21:04PM +0100, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> > 
> > Cc: "Ed L. Cashin" <ed.cashin@....org>
> > Cc: Jens Axboe <axboe@...nel.dk>
> > Cc: linux-block@...r.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  drivers/block/aoe/aoeblk.c | 13 +------------
> >  1 file changed, 1 insertion(+), 12 deletions(-)
> > 
> > diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> > index e2c6aae2d636..b602646bfa04 100644
> > --- a/drivers/block/aoe/aoeblk.c
> > +++ b/drivers/block/aoe/aoeblk.c
> > @@ -207,14 +207,7 @@ aoedisk_add_debugfs(struct aoedev *d)
> >  	else
> >  		p++;
> >  	BUG_ON(*p == '\0');
> > -	entry = debugfs_create_file(p, 0444, aoe_debugfs_dir, d,
> > -				    &aoe_debugfs_fops);
> > -	if (IS_ERR_OR_NULL(entry)) {
> > -		pr_info("aoe: cannot create debugfs file for %s\n",
> > -			d->gd->disk_name);
> > -		return;
> > -	}
> > -	BUG_ON(d->debugfs);
> > +	debugfs_create_file(p, 0444, aoe_debugfs_dir, d, &aoe_debugfs_fops);
> >  	d->debugfs = entry;
> 
> Now entry is uninitialized here when we assign it to d->debugfs.

Ah, good catch, I'll go fix this up and post a v2, sorry about that.

greg k-h