linux-kernel - Re: [PATCH v3] tty: moxa: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190123070623.GE27466@kroah.com>
Date:   Wed, 23 Jan 2019 08:06:23 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Antoine Robertson <antoinerbrtsn@...il.com>
Cc:     jslaby@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] tty: moxa: Fix coding style issues

On Tue, Jan 22, 2019 at 05:30:55PM -0500, Antoine Robertson wrote:
> Fix coding style issues

That is really vague, you need to say exactly what type of coding style
fixes you made here.

And if you made more than one "type" of fix, then you need to break the
patch up into a series, only doing one "type" of fix per patch.

Yeah, that's a pain for when there are only tiny things that need to be
changed, but that way it makes it easier for reviewers, and for fixing
if it turns out any of your changes was not ok.

I recommend, if you want to do coding style fixes, to do so in the
drivers/staging/ part of the kernel.  That area has a lot more work to
be done and you don't end up doing tiny things like this.

thanks,

greg k-h