linux-kernel - Re: [PATCH 3/7] crypto: axis: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad5fd669-a717-ee17-cebf-fc6b717ba46c@axis.com>
Date:   Wed, 23 Jan 2019 08:37:06 +0100
From:   Lars Persson <lars.persson@...s.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        David Miller <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        "Jesper Nilsson" <jespern@...s.com>,
        Lars Persson <larper@...s.com>, <linux-arm-kernel@...s.com>
Subject: Re: [PATCH 3/7] crypto: axis: no need to check return value of
 debugfs_create functions


On 1/22/19 4:14 PM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Jesper Nilsson <jesper.nilsson@...s.com>
> Cc: Lars Persson <lars.persson@...s.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-arm-kernel@...s.com
> Cc: linux-crypto@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>   drivers/crypto/axis/artpec6_crypto.c | 9 ---------
>   1 file changed, 9 deletions(-)

Acked-by: Lars Persson <lars.persson@...s.com>

Thanks,
  Lars