linux-kernel - [PATCH -next] watchdog: pika_wdt: drop pointless static qualifier in pikawdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Jan 2019 17:05:24 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <wim@...ux-watchdog.org>, <linux@...ck-us.net>
CC:     <linux-kernel@...r.kernel.org>, <linux-watchdog@...r.kernel.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH -next] watchdog: pika_wdt: drop pointless static qualifier in pikawdt_init

There is no need to have the 'post1' variable static since
new value always be assigned before use it.

Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 drivers/watchdog/pika_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c
index e0a6f8c..bb97f5b 100644
--- a/drivers/watchdog/pika_wdt.c
+++ b/drivers/watchdog/pika_wdt.c
@@ -225,7 +225,7 @@ static int __init pikawdt_init(void)
 {
 	struct device_node *np;
 	void __iomem *fpga;
-	static u32 post1;
+	u32 post1;
 	int ret;
 
 	np = of_find_compatible_node(NULL, NULL, "pika,fpga");
-- 
2.7.0