linux-kernel - Re: [PATCH v2 -next] mtd: docg3: Fix a possible memory leak of mtd->name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b720e309-2f51-d08b-1713-8afd438be6d9@huawei.com>
Date:   Wed, 23 Jan 2019 17:09:19 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <robert.jarzmik@...e.fr>, <dwmw2@...radead.org>,
        <computersforpeace@...il.com>, <bbrezillon@...nel.org>,
        <marek.vasut@...il.com>, <richard@....at>
CC:     <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH v2 -next] mtd: docg3: Fix a possible memory leak of
 mtd->name

Pls ignore this err patch.

On 2019/1/23 17:07, YueHaibing wrote:
> In case DOC_CHIPID_G3, mtd->name is not freed in err handling path,
> which is alloced by kasprintf(). Fix this by using devm_kasprintf().
> 
> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: use devm_kasprintf
> ---
>  drivers/mtd/devices/docg3.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> index 4c94fc0..af824d3 100644
> --- a/drivers/mtd/devices/docg3.c
> +++ b/drivers/mtd/devices/docg3.c
> @@ -1767,8 +1767,8 @@ static int __init doc_set_driver_info(int chip_id, struct mtd_info *mtd)
>  
>  	switch (chip_id) {
>  	case DOC_CHIPID_G3:
> -		mtd->name = kasprintf(GFP_KERNEL, "docg3.%d",
> -				      docg3->device_id);
> +		mtd->name = devm_kasprintf(GFP_KERNEL, "docg3.%d",
> +					   docg3->device_id);
>  		if (!mtd->name)
>  			return -ENOMEM;
>  		docg3->max_block = 2047;
>