linux-kernel - Re: [PATCH 09/24] dt-bindings: PCI: Document "atu" reg-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f2fa7cd-b5a3-e466-6cbc-305f15836241@ti.com>
Date:   Wed, 23 Jan 2019 15:34:28 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Rob Herring <robh@...nel.org>
CC:     Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jingoo Han <jingoohan1@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Murali Karicheri <m-karicheri2@...com>,
        Jesper Nilsson <jesper.nilsson@...s.com>,
        <linux-pci@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-arm-kernel@...s.com>
Subject: Re: [PATCH 09/24] dt-bindings: PCI: Document "atu" reg-names

Hi Rob,

On 22/01/19 6:18 AM, Rob Herring wrote:
> On Mon, Jan 14, 2019 at 06:54:09PM +0530, Kishon Vijay Abraham I wrote:
>> Document "atu" reg-names required to get the register space for ATU in
>> Synopsys designware core version >= 4.80.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>> ---
>>  Documentation/devicetree/bindings/pci/designware-pcie.txt | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> index c124f9bc11f3..5561a1c060d0 100644
>> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> @@ -4,8 +4,11 @@ Required properties:
>>  - compatible:
>>  	"snps,dw-pcie" for RC mode;
>>  	"snps,dw-pcie-ep" for EP mode;
>> -- reg: Should contain the configuration address space.
>> -- reg-names: Must be "config" for the PCIe configuration space.
>> +- reg: For designware cores version < 4.80 contains the configuration
>> +       address space. For designware core version >= 4.80, contains
>> +       the configuration and ATU address space
>> +- reg-names: Must be "config" for the PCIe configuration space and "atu" for
>> +	     the ATU address space.
> 
> I'm pretty sure we already have other platforms with an ATU. Those all 
> just represent it with the other ctrl registers? So maybe this is TI 
> specific that it is separate. Or should have some conditional like 'if 
> the ATU space is separate, the reg-name should be atu'.

This is specific to Synopsys Designware version >= 4.80 and not to TI. The
first platform used a fixed offset to get the atu_base which is incorrect.

In the "reg" binding I've noted this dependency.

Thanks
Kishon