linux-kernel - Re: [PATCH 4/7] crypto: cavium: zip: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Jan 2019 13:30:19 +0000
From:   Jan Glauber <Jan.Glauber@...ium.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        David Miller <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "Richter, Robert" <Robert.Richter@...ium.com>
Subject: Re: [PATCH 4/7] crypto: cavium: zip: no need to check return value of
 debugfs_create functions

On Tue, Jan 22, 2019 at 04:14:19PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Robert Richter <rrichter@...ium.com>
> Cc: Jan Glauber <jglauber@...ium.com>
> Cc: linux-crypto@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/crypto/cavium/zip/zip_main.c | 52 ++++++----------------------
>  1 file changed, 11 insertions(+), 41 deletions(-)

Reviewed-by: Jan Glauber <jglauber@...ium.com>

thanks,
Jan