linux-kernel - Re: [PATCH v3] selftests: add binderfs selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1893da7-1222-d303-04c7-fb0500b55088@kernel.org>
Date:   Wed, 23 Jan 2019 07:15:01 -0700
From:   shuah <shuah@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Christian Brauner <christian@...uner.io>
Cc:     tkjos@...roid.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        arve@...roid.com, maco@...roid.com, joel@...lfernandes.org,
        tkjos@...gle.com, shuah <shuah@...nel.org>
Subject: Re: [PATCH v3] selftests: add binderfs selftests

On 1/23/19 4:00 AM, Greg KH wrote:
> On Wed, Jan 23, 2019 at 11:54:58AM +0100, Christian Brauner wrote:
>> On Thu, Jan 17, 2019 at 12:48:54PM +0100, Christian Brauner wrote:
>>> This adds the promised selftest for binderfs. It will verify the following
>>> things:
>>> - binderfs mounting works
>>> - binder device allocation works
>>> - performing a binder ioctl() request through a binderfs device works
>>> - binder device removal works
>>> - binder-control removal fails
>>> - binderfs unmounting works
>>>
>>> The tests are performed both privileged and unprivileged. The latter
>>> verifies that binderfs behaves correctly in user namespaces.
>>>
>>> Cc: Todd Kjos <tkjos@...gle.com>
>>> Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
>>
>> Hey Shuah,
>>
>> If you're ok with the patch in its current form, can you please make
>> sure that this still lands in 5.0? If at all possible I'd like to have
>> all ducks in a row and release binderfs with selftests and everything.
>> :)
> 

The patch is good and I was planning to get this into 5.1.

> I can take it in my tree with the other binderfs patches if I can get an
> ack from Shuah.
> 

Great. It is good for the test patch to go with the other binderfs
patches.

Acked-by: Shuah Khan <shuah@...nel.org>

thanks,
-- Shuah