linux-kernel - Re: [PATCH 10/12] perf script: Add support for PERF_SAMPLE_CODE_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f62f2b34-09a8-c107-b3d0-59e50b4753d3@linux.intel.com>
Date:   Wed, 23 Jan 2019 09:40:47 -0500
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     peterz@...radead.org, acme@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, linux-kernel@...r.kernel.org, eranian@...gle.com,
        jolsa@...hat.com, namhyung@...nel.org
Subject: Re: [PATCH 10/12] perf script: Add support for
 PERF_SAMPLE_CODE_PAGE_SIZE



On 1/22/2019 12:11 PM, Andi Kleen wrote:
>> +	PERF_OUTPUT_CODE_PAGE_SIZE  = 1UL << 32,
> 
> That won't work on 32bit. You need 1ULL
> 
> Also might want to audit that noone puts these flags into
> an int.
> 

I checked the codes, and there is no one puts the flags into an int.

I will use ULL in V2.

Thanks,
Kan