linux-kernel - Re: [PATCH] tools/testing/selftests/powerpc: Add Anton's null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b98b303-d0d4-9f1d-9c47-fde0afb1306c@c-s.fr>
Date:   Wed, 23 Jan 2019 15:56:06 +0100
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Rui Teng <rui.teng@...ux.vnet.ibm.com>,
        Anton Blanchard <anton@....ibm.com>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, Michael Neuling <mikey@...ling.org>,
        Shuah Khan <shuah@...nel.org>, Cyril Bur <cyrilbur@...il.com>
Subject: Re: [PATCH] tools/testing/selftests/powerpc: Add Anton's null_syscall
 benchmark to the selftests



Le 27/09/2016 à 16:10, Rui Teng a écrit :
> From: Anton Blanchard <anton@...ibm.com>
> 
> Pull in a version of Anton's null_syscall benchmark:
> http://ozlabs.org/~anton/junkcode/null_syscall.c
> Into tools/testing/selftests/powerpc/benchmarks.
> 
> Suggested-by: Michael Ellerman <mpe@...erman.id.au>
> Signed-off-by: Anton Blanchard <anton@...ibm.com>
> Signed-off-by: Rui Teng <rui.teng@...ux.vnet.ibm.com>
> ---
>   .../testing/selftests/powerpc/benchmarks/Makefile  |   2 +-
>   .../selftests/powerpc/benchmarks/null_syscall.c    | 157 +++++++++++++++++++++
>   2 files changed, 158 insertions(+), 1 deletion(-)
>   create mode 100644 tools/testing/selftests/powerpc/benchmarks/null_syscall.c
> 

[...]

> +
> +static void do_null_syscall(unsigned long nr)
> +{
> +	unsigned long i;
> +
> +	for (i = 0; i < nr; i++)
> +		getppid();
> +}
> +

Looks like getppid() performs a rcu_read_lock(). Is that what we want ?

Shouldn't we use getpid() instead for a lighter syscall ?

Christophe