linux-kernel - Re: [PATCH][V2] selftests: cpu-hotplug: fix case where CPUs offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c18c3293-631d-2deb-794d-b7057ea2c50d@kernel.org>
Date:   Wed, 23 Jan 2019 08:07:53 -0700
From:   shuah <shuah@...nel.org>
To:     Colin Ian King <colin.king@...onical.com>,
        linux-kselftest@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH][V2] selftests: cpu-hotplug: fix case where CPUs offline >
 CPUs present

On 1/23/19 6:25 AM, Colin Ian King wrote:
> ping?
> 
> On 10/01/2019 12:38, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The cpu-hotplug test assumes that we can offline the maximum CPU as
>> described by /sys/devices/system/cpu/offline.  However, in the case
>> where the number of CPUs exceeds like kernel configuration then
>> the offline count can be greater than the present count and we end
>> up trying to test the offlining of a CPU that is not available to
>> offline.  Fix this by testing the maximum present CPU instead.
>>
>> Also, the test currently offlines the CPU and does not online it,
>> so fix this by onlining the CPU after the test.
>>
>> Fixes: d89dffa976bc ("fault-injection: add selftests for cpu and memory hotplug")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>
>> ---
>>
>> V2: remove some debug and an empty line

Sorry for the delay. I will take this for 5.0-rc5

thanks,
-- Shuah