linux-kernel - Re: [Intel-wired-lan] [PATCH 1/3] treewide: Lift switch variables out of switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d8a6120ea335d74c41a5fba3754518ea60e936e.camel@intel.com>
Date:   Wed, 23 Jan 2019 08:51:38 -0800
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Cc:     dev@...nvswitch.org, Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        netdev@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
        linux-usb@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-mm@...ck.org, linux-security-module@...r.kernel.org,
        kernel-hardening@...ts.openwall.com,
        intel-wired-lan@...ts.osuosl.org, linux-fsdevel@...r.kernel.org,
        xen-devel@...ts.xenproject.org, Laura Abbott <labbott@...hat.com>,
        linux-kbuild@...r.kernel.org,
        Alexander Popov <alex.popov@...ux.com>
Subject: Re: [Intel-wired-lan] [PATCH 1/3] treewide: Lift switch variables
 out of switches

On Wed, 2019-01-23 at 03:03 -0800, Kees Cook wrote:
> Variables declared in a switch statement before any case statements
> cannot be initialized, so move all instances out of the switches.
> After this, future always-initialized stack variables will work
> and not throw warnings like this:
> 
> fs/fcntl.c: In function ‘send_sigio_to_task’:
> fs/fcntl.c:738:13: warning: statement will never be executed [-
> Wswitch-unreachable]
>    siginfo_t si;
>              ^~
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

For the e1000 changes.

> ---
>  arch/x86/xen/enlighten_pv.c                   |  7 ++++---
>  drivers/char/pcmcia/cm4000_cs.c               |  2 +-
>  drivers/char/ppdev.c                          | 20 ++++++++---------
> --
>  drivers/gpu/drm/drm_edid.c                    |  4 ++--
>  drivers/gpu/drm/i915/intel_display.c          |  2 +-
>  drivers/gpu/drm/i915/intel_pm.c               |  4 ++--
>  drivers/net/ethernet/intel/e1000/e1000_main.c |  3 ++-
>  drivers/tty/n_tty.c                           |  3 +--
>  drivers/usb/gadget/udc/net2280.c              |  5 ++---
>  fs/fcntl.c                                    |  3 ++-
>  mm/shmem.c                                    |  5 +++--
>  net/core/skbuff.c                             |  4 ++--
>  net/ipv6/ip6_gre.c                            |  4 ++--
>  net/ipv6/ip6_tunnel.c                         |  4 ++--
>  net/openvswitch/flow_netlink.c                |  7 +++----
>  security/tomoyo/common.c                      |  3 ++-
>  security/tomoyo/condition.c                   |  7 ++++---
>  security/tomoyo/util.c                        |  4 ++--
>  18 files changed, 45 insertions(+), 46 deletions(-)


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)