linux-kernel - Re: [PATCH net-next] net/mlx4: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e27972ea-dc6a-569d-638f-293067c95059@embeddedor.com>
Date:   Wed, 23 Jan 2019 12:09:07 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     David Miller <davem@...emloft.net>
Cc:     tariqt@...lanox.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx4: Mark expected switch fall-through



On 1/23/19 11:08 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
> Date: Wed, 23 Jan 2019 02:05:11 -0600
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_eq_int’:
>> drivers/net/ethernet/mellanox/mlx4/mlx4.h:219:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>   if (mlx4_debug_level)      \
>>      ^
>> drivers/net/ethernet/mellanox/mlx4/eq.c:558:4: note: in expansion of macro ‘mlx4_dbg’
>>     mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT. srq_no=0x%x, eq 0x%x\n",
>>     ^~~~~~~~
>> drivers/net/ethernet/mellanox/mlx4/eq.c:561:3: note: here
>>    case MLX4_EVENT_TYPE_SRQ_CATAS_ERROR:
>>    ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Applied.
> 

Thank you both, Tariq and David.

--
Gustavo