linux-kernel - Re: [PATCH v3 5/5] usb :fsl: Change string format for errata property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Jan 2019 14:17:00 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Yinbo Zhu <yinbo.zhu@....com>
cc:     Xiaobo Xie <xiaobo.xie@....com>, Jerry Huang <jerry.huang@....com>,
        Ran Wang <ran.wang_1@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ramneek Mehresh <ramneek.mehresh@...escale.com>,
        Nikhil Badola <nikhil.badola@...escale.com>,
        Suresh Gupta <suresh.gupta@...escale.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 5/5] usb :fsl: Change string format for errata property

On Wed, 23 Jan 2019, Yinbo Zhu wrote:

> From: Nikhil Badola <nikhil.badola@...escale.com>
> 
> Remove USB errata checking code from driver. Applicability of erratum
> is retrieved by reading corresponding property in device tree.
> This property is written during device tree fixup.
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@...escale.com>
> Signed-off-by: Nikhil Badola <nikhil.badola@...escale.com>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@....com>
> ---
>  drivers/usb/host/fsl-mph-dr-of.c |   14 ++++----------
>  1 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index bdc8812..ae8f60f 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -224,16 +224,10 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
>  		of_property_read_bool(np, "fsl,usb-erratum-a005275");
>  	pdata->has_fsl_erratum_a005697 =
>  		of_property_read_bool(np, "fsl,usb_erratum-a005697");
> -
> -	if (of_get_property(np, "fsl,usb_erratum_14", NULL))
> -		pdata->has_fsl_erratum_14 = 1;
> -	else
> -		pdata->has_fsl_erratum_14 = 0;
> -
> -	if (of_get_property(np, "fsl,erratum_a006918", NULL))
> -		pdata->has_fsl_erratum_a006918 = 1;
> -	else
> -		pdata->has_fsl_erratum_a006918 = 0;
> +	pdata->has_fsl_erratum_a006918 =
> +		of_property_read_bool(np, "fsl,usb_erratum-a006918");
> +	pdata->has_fsl_erratum_14 =
> +		of_property_read_bool(np, "fsl,usb_erratum-14");

Why go to the trouble of adding bad code for has_fsl_erratum_a006918 in 
patch 4/5 if you're going to change that code here?  Why not just add 
the correct code in the first place?

Alan Stern

>  
>  	/*
>  	 * Determine whether phy_clk_valid needs to be checked
>