[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190123201506.GG3097@redhat.com>
Date: Wed, 23 Jan 2019 15:15:06 -0500
From: Jerome Glisse <jglisse@...hat.com>
To: Dave Hansen <dave.hansen@...el.com>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>, dave@...1.net,
dan.j.williams@...el.com, dave.jiang@...el.com, zwisler@...nel.org,
vishal.l.verma@...el.com, thomas.lendacky@....com,
akpm@...ux-foundation.org, mhocko@...e.com,
linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, ying.huang@...el.com, fengguang.wu@...el.com,
bp@...e.de, bhelgaas@...gle.com, baiyaowei@...s.chinamobile.com,
tiwai@...e.de
Subject: Re: [PATCH 2/4] mm/memory-hotplug: allow memory resources to be
children
On Wed, Jan 23, 2019 at 12:03:54PM -0800, Dave Hansen wrote:
> On 1/16/19 3:38 PM, Jerome Glisse wrote:
> > So right now i would rather that we keep properly reporting this
> > hazard so that at least we know it failed because of that. This
> > also include making sure that we can not register private memory
> > as a child of an un-busy resource that does exist but might not
> > have yet been claim by its rightful owner.
>
> I can definitely keep the warning in. But, I don't think there's a
> chance of HMM registering a IORES_DESC_DEVICE_PRIVATE_MEMORY region as
> the child of another. The region_intersects() check *should* find that:
Sounds fine to (just keep the warning).
Cheers,
Jérôme
>
> > for (; addr > size && addr >= iomem_resource.start; addr -= size) {
> > ret = region_intersects(addr, size, 0, IORES_DESC_NONE);
> > if (ret != REGION_DISJOINT)
> > continue;
>
Powered by blists - more mailing lists