linux-kernel - [PATCH v2 3/3] bitops.h: set_mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1548275584-18096-4-git-send-email-vgupta@synopsys.com>
Date:   Wed, 23 Jan 2019 12:33:04 -0800
From:   Vineet Gupta <vineet.gupta1@...opsys.com>
To:     <linux-kernel@...r.kernel.org>
CC:     <linux-snps-arc@...ts.infradead.org>, <linux-mm@...ck.org>,
        <peterz@...radead.org>, <mark.rutland@....com>,
        Vineet Gupta <vineet.gupta1@...opsys.com>,
        Miklos Szeredi <mszeredi@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Jani Nikula <jani.nikula@...el.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH v2 3/3] bitops.h: set_mask_bits() to return old value

| > Also, set_mask_bits is used in fs quite a bit and we can possibly come up
| > with a generic llsc based implementation (w/o the cmpxchg loop)
|
| May I also suggest changing the return value of set_mask_bits() to old.
|
| You can compute the new value given old, but you cannot compute the old
| value given new, therefore old is the better return value. Also, no
| current user seems to use the return value, so changing it is without
| risk.

Link: http://lkml.kernel.org/g/20150807110955.GH16853@twins.programming.kicks-ass.net
Suggested-by: Peter Zijlstra <peterz@...radead.org>
Cc: Miklos Szeredi <mszeredi@...hat.com>
Cc: Ingo Molnar <mingo@...nel.org>
Cc: Jani Nikula <jani.nikula@...el.com>
Cc: Chris Wilson <chris@...is-wilson.co.uk>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Reviewed-by: Anthony Yznaga <anthony.yznaga@...cle.com>
Acked-by: Will Deacon <will.deacon@....com>
Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
---
 include/linux/bitops.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/bitops.h b/include/linux/bitops.h
index 705f7c442691..602af23b98c7 100644
--- a/include/linux/bitops.h
+++ b/include/linux/bitops.h
@@ -246,7 +246,7 @@ static __always_inline void __assign_bit(long nr, volatile unsigned long *addr,
 		new__ = (old__ & ~mask__) | bits__;		\
 	} while (cmpxchg(ptr, old__, new__) != old__);		\
 								\
-	new__;							\
+	old__;							\
 })
 #endif
 
-- 
2.7.4