linux-kernel - Re: [PATCH 3/7] coresight: Use event attributes for sink selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190123210333.GZ27931@hirez.programming.kicks-ass.net>
Date:   Wed, 23 Jan 2019 22:03:33 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     acme@...nel.org, gregkh@...uxfoundation.org, mingo@...hat.com,
        tglx@...utronix.de, alexander.shishkin@...ux.intel.com,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        will.deacon@....com, mark.rutland@....com, jolsa@...hat.com,
        namhyung@...nel.org, adrian.hunter@...el.com, ast@...nel.org,
        hpa@...or.com, suzuki.poulose@....com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/7] coresight: Use event attributes for sink selection

On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote:
> +	/* First get the selected sink from user space. */
> +	sink = coresight_get_sink_by_id(event->attr.config2);

(I know there's a new version out, I'll go look there shortly)

should this patch not also have something like:

PMU_FORMAT_ATTR(sinkid, "config2:0-63");

> +	if (!sink)
> +		sink = coresight_get_enabled_sink(true);
>  	if (!sink || !sink_ops(sink)->alloc_buffer)
>  		goto err;