linux-kernel - Re: [PATCH] staging: ks7010: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190123222131.GA10543@mmccoy>
Date:   Wed, 23 Jan 2019 17:21:31 -0500
From:   Matt McCoy <mattmccoy110@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Quytelda Kahja <quytelda@...alin.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ks7010: remove unnecessary parentheses

On Tue, Jan 22, 2019 at 06:45:37PM -0800, Joe Perches wrote:
> On Tue, 2019-01-22 at 21:18 -0500, Matt McCoy wrote:
> > Remove unnecessary parentheses reported by checkpatch.
> []
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> []
> > @@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
> >  		   "- rate_set_size=%d\n",
> >  		   ap->bssid[0], ap->bssid[1], ap->bssid[2],
> >  		   ap->bssid[3], ap->bssid[4], ap->bssid[5],
> > -		   &(ap->ssid.body[0]),
> > +		   &ap->ssid.body[0],
> >  		   ap->rate_set.body[0], ap->rate_set.body[1],
> >  		   ap->rate_set.body[2], ap->rate_set.body[3],
> >  		   ap->rate_set.body[4], ap->rate_set.body[5],
> 
> This bit:
> 
> []
> 	netdev_dbg(priv->net_dev, "Link AP\n"
> 		   "- bssid=%02X:%02X:%02X:%02X:%02X:%02X\n"
> []
> 		   ap->bssid[0], ap->bssid[1], ap->bssid[2],
> 
> should instead use the vsprintf %pM extension
> 
> 		"- bssid: %pM\n"
> []
> 		ap->bssid,
> 
>

Should I just make a v2 of this patch with 2 parts ?
One being this change and the other using the %pM extension.