linux-kernel - Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875zufx95e.fsf@concordia.ellerman.id.au>
Date:   Thu, 24 Jan 2019 10:10:37 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     LEROY Christophe <christophe.leroy@....fr>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Paul Mackerras <paulus@...ba.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK

LEROY Christophe <christophe.leroy@....fr> writes:
> Michael Ellerman <mpe@...erman.id.au> a écrit :
>
>> Christophe Leroy <christophe.leroy@....fr> writes:
>>
>>> The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which
>>> moves the thread_info into task_struct.
>>>
>>> Moving thread_info into task_struct has the following advantages:
>>> - It protects thread_info from corruption in the case of stack
>>> overflows.
>>> - Its address is harder to determine if stack addresses are
>>> leaked, making a number of attacks more difficult.
>>>
>>> Changes since v12:
>>>  - Patch 1: Taken comment from Mike (re-introduced the 'panic' in  
>>> case memblock allocation fails in setup_64.c
>>>  - Patch 1: Added alloc_stack() function in setup_32.c to also  
>>> panic in case of allocation failure.
>>
>> Hi Christophe,
>>
>> I can't get this series to boot on qemu mac99. I'm getting eg:
>
> Problem new with version 13 or it is the first time you test ?

I did test a previous version of the series, but I'm not sure if I
tested pmac32 before. So I don't have a known good version.

>> [    0.981514] NFS: Registering the id_resolver key type
>> [    0.981752] Key type id_resolver registered
>> [    0.981868] Key type id_legacy registered
>> [    0.995711] Unrecoverable exception 0 at 0 (msr=0)
>> [    0.996091] Oops: Unrecoverable exception, sig: 6 [#1]
>> [    0.996314] BE PAGE_SIZE=4K MMU=Hash PowerMac
>> [    0.996617] Modules linked in:
>> [    0.996869] CPU: 0 PID: 416 Comm: modprobe Not tainted  
>> 5.0.0-rc2-gcc-7.3.0-00043-g53f2de798792 #342
>
> Comm:modprobe  ==> Something wrong with modules ? I never tested with  
> CONFIG_MODULES.

Yep good clue.

cheers