linux-kernel - Re: [for next][PATCH v3 1/2] platform/x86: Fix unmet dependency warning for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VerwCxYqozQmaJZL8tcbfDFLBp+nTheP0Ran4qWPqTcLw@mail.gmail.com>
Date:   Thu, 24 Jan 2019 23:32:56 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sinan Kaya <okaya@...nel.org>
Cc:     linux-next <linux-next@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        "open list:X86 PLATFORM DRIVERS" 
        <platform-driver-x86@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [for next][PATCH v3 1/2] platform/x86: Fix unmet dependency
 warning for ACPI_CMPC

On Thu, Jan 24, 2019 at 9:31 PM Sinan Kaya <okaya@...nel.org> wrote:
>
> Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
> warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
>
> ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE
> depends on BACKLIGHT_LCD_SUPPORT.
>
> Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix
>
> WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
>   Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n]
>   Selected by [y]:
>   - ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n)
>

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

for both patches in case Rafael takes care of them.

> Signed-off-by: Sinan Kaya <okaya@...nel.org>
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 5e2109c54c7c..11810591840d 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -905,6 +905,7 @@ config TOSHIBA_WMI
>  config ACPI_CMPC
>         tristate "CMPC Laptop Extras"
>         depends on ACPI && INPUT
> +       depends on BACKLIGHT_LCD_SUPPORT
>         depends on RFKILL || RFKILL=n
>         select BACKLIGHT_CLASS_DEVICE
>         help
> --
> 2.19.0
>


-- 
With Best Regards,
Andy Shevchenko