linux-kernel - Re: [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABDvA==mnccSCBSpO2-ksnStKN8Zw-Ryuj2qY5970NbTjn9-OA@mail.gmail.com>
Date:   Fri, 25 Jan 2019 08:05:29 +1000
From:   Ben Skeggs <bskeggs@...hat.com>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     David Airlie <airlied@...ux.ie>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        nouveau <nouveau@...ts.freedesktop.org>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks
 object size

On Fri, Jan 25, 2019 at 3:26 AM Colin Ian King <colin.king@...onical.com> wrote:
>
> ping?
I've pushed this, and the others you pinged about, to my tree.

Thank you,
Ben.

>
> On 04/09/2018 16:23, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> >
> > Don't populate the array vsoff on the stack but instead make it
> > static. Makes the object code smaller by 67 bytes:
> >
> > Before:
> >    text          data     bss     dec     hex filename
> >    5753           112       0    5865    16e9 .../nouveau/nvkm/subdev/bios/dp.o
> >
> > After:
> >    text          data     bss     dec     hex filename
> >    5622           176       0    5798    16a6 .../nouveau/nvkm/subdev/bios/dp.o
> >
> > (gcc version 8.2.0 x86_64)
> >
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > index 3133b28f849c..b099d1209be8 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > @@ -212,7 +212,7 @@ nvbios_dpcfg_match(struct nvkm_bios *bios, u16 outp, u8 pc, u8 vs, u8 pe,
> >       u16 data;
> >
> >       if (*ver >= 0x30) {
> > -             const u8 vsoff[] = { 0, 4, 7, 9 };
> > +             static const u8 vsoff[] = { 0, 4, 7, 9 };
> >               idx = (pc * 10) + vsoff[vs] + pe;
> >               if (*ver >= 0x40 && *ver <= 0x41 && *hdr >= 0x12)
> >                       idx += nvbios_rd08(bios, outp + 0x11) * 40;
> >
>