lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Jan 2019 15:05:03 +0800 From: Peter Xu <peterx@...hat.com> To: Jerome Glisse <jglisse@...hat.com> Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>, Maya Gokhale <gokhale2@...l.gov>, Johannes Weiner <hannes@...xchg.org>, Martin Cracauer <cracauer@...s.org>, Denis Plotnikov <dplotnikov@...tuozzo.com>, Shaohua Li <shli@...com>, Andrea Arcangeli <aarcange@...hat.com>, Mike Kravetz <mike.kravetz@...cle.com>, Marty McFadden <mcfadden8@...l.gov>, Mike Rapoport <rppt@...ux.vnet.ibm.com>, Mel Gorman <mgorman@...e.de>, "Kirill A . Shutemov" <kirill@...temov.name>, "Dr . David Alan Gilbert" <dgilbert@...hat.com> Subject: Re: [PATCH RFC 04/24] mm: gup: allow VM_FAULT_RETRY for multiple times On Mon, Jan 21, 2019 at 11:24:55AM -0500, Jerome Glisse wrote: > On Mon, Jan 21, 2019 at 03:57:02PM +0800, Peter Xu wrote: > > This is the gup counterpart of the change that allows the VM_FAULT_RETRY > > to happen for more than once. > > > > Signed-off-by: Peter Xu <peterx@...hat.com> > > So it would be nice to add a comment in the code and in the commit message > about possible fault starvation (mostly due to previous patch changes) as > if some one experience that and try to bisect it might overlook the commit. > > Otherwise: > > Reviewed-by: Jérôme Glisse <jglisse@...hat.com> Jerome, can I still keep this r-b if I'm going to fix the starvation issue you mentioned in previous patch about lock page? Regards, -- Peter Xu
Powered by blists - more mailing lists