linux-kernel - Re: [PATCH 1/2] mm: Rename ambiguously named memory.stat counters and functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190124010638.GB9055@chrisdown.name>
Date:   Wed, 23 Jan 2019 20:06:38 -0500
From:   Chris Down <chris@...isdown.name>
To:     Roman Gushchin <guro@...com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>, Tejun Heo <tj@...nel.org>,
        Dennis Zhou <dennis@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH 1/2] mm: Rename ambiguously named memory.stat counters
 and functions

Roman Gushchin writes:
>I'd personally go with memcg_vmstat_percpu. Not insisting,
>but you end up using both vmstat and vmstats, which isn't very
>consistent.

Yeah, we also have similar naming in accumulated_vmstats. Hmm, let me think 
about this a bit and get back to you tomorrow. The main bit I was concerned 
about was memory_events vs. events -- I don't really have strong opinions on 
the percpu struct's exact naming/plurality.

>Other than that looks good to me. Please, feel free to add
>Acked-by: Roman Gushchin <guro@...com>

Thanks!