linux-kernel - Re: [for next][PATCH 1/2] platform/x86: Fix unmet dependency warning for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3681650.SPxszaOeRQ@aspire.rjw.lan>
Date:   Thu, 24 Jan 2019 11:52:57 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Sinan Kaya <okaya@...nel.org>, Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Cc:     linux-next@...r.kernel.org, linux-acpi@...r.kernel.org,
        "open list:X86 PLATFORM DRIVERS" 
        <platform-driver-x86@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [for next][PATCH 1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC

On Monday, January 21, 2019 11:46:43 PM CET Sinan Kaya wrote:
> Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
> warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
> 
> ACPI_CMPC selects BACKLIGHT_LCD_SUPPORT but BACKLIGHT_LCD_SUPPORT
> depends on BACKLIGHT_LCD_SUPPORT.
> 
> Copy this dependency into ACPI_CMPC.
> 
> Signed-off-by: Sinan Kaya <okaya@...nel.org>
> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 5e2109c54c7c..b84c2c5b6684 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -904,7 +904,7 @@ config TOSHIBA_WMI
>  
>  config ACPI_CMPC
>  	tristate "CMPC Laptop Extras"
> -	depends on ACPI && INPUT
> +	depends on ACPI && INPUT && BACKLIGHT_LCD_SUPPORT
>  	depends on RFKILL || RFKILL=n
>  	select BACKLIGHT_CLASS_DEVICE
>  	help
> 

Andy/Darren, these two seem to be for you, but I can take them too as
related to ACPI tagentially, so please let me know.