linux-kernel - Re: [PATCH] arm64: dts: hikey: Revert "Enable HS200 mode on eMMC"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <107a6e2e-ddd8-cbc1-5680-1b5899665327@arm.com>
Date:   Thu, 24 Jan 2019 11:18:42 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     John Stultz <john.stultz@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Ryan Grachek <ryan@...ted.us>,
        Alistair Strachan <astrachan@...gle.com>,
        Wei Xu <xuwei5@...ilicon.com>,
        Rob Herring <robh+dt@...nel.org>,
        "stable #4 . 17+" <stable@...r.kernel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: hikey: Revert "Enable HS200 mode on eMMC"

Hi John,

On 23/01/2019 20:06, John Stultz wrote:
> From: Alistair Strachan <astrachan@...gle.com>
> 
> This reverts commit abd7d0972a192ee653efc7b151a6af69db58f2bb. This
> change was already partially reverted by John Stultz in commit
> 9c6d26df1fae ("arm64: dts: hikey: Fix eMMC corruption regression").
> 
> This change appears to cause controller resets and block read failures
> which prevents successful booting on some hikey boards.

FWIW, you might want to have a play with the pinctrl settings - I've 
seen various flakiness with HS200 eMMCs on Rockchip boards which could 
be solved by bumping up the drive strength.

Robin.

> Cc: Ryan Grachek <ryan@...ted.us>
> Cc: Wei Xu <xuwei5@...ilicon.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: devicetree@...r.kernel.org
> Cc: stable <stable@...r.kernel.org> #4.17+
> Signed-off-by: Alistair Strachan <astrachan@...gle.com>
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>   arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 6102350..7092460 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -300,7 +300,6 @@
>   
>   		dwmmc_0: dwmmc0@...3d000 {
>   			cap-mmc-highspeed;
> -			mmc-hs200-1_8v;
>   			non-removable;
>   			bus-width = <0x8>;
>   			vmmc-supply = <&ldo19>;
>