linux-kernel - Re: [PATCH] net: usb: asix: ax88772_bind return error when hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2233b8499110f3b2afcaf44f7f6ee820f7e0b36e.camel@toradex.com>
Date:   Thu, 24 Jan 2019 14:03:38 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "zhang.run@....com.cn" <zhang.run@....com.cn>
CC:     "wang.yi59@....com.cn" <wang.yi59@....com.cn>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xue.zhihong@....com.cn" <xue.zhihong@....com.cn>,
        "lynxis@...0.eu" <lynxis@...0.eu>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] net: usb: asix: ax88772_bind return error when hw_reset
 fail

On Thu, 2019-01-24 at 13:48 +0800, Zhang Run wrote:
> The ax88772_bind() should return error code immediately when the PHY
> was not reset properly through ax88772a_hw_reset().
> Otherwise, The asix_get_phyid() will block when get the PHY 
> Identifier from the PHYSID1 MII registers through asix_mdio_read() 
> due to the PHY isn't ready. Furthermore, it will produce a lot of 
> error message cause system crash.As follows:
> asix 1-1:1.0 (unnamed net_device) (uninitialized): Failed to write
>  reg index 0x0000: -71
> asix 1-1:1.0 (unnamed net_device) (uninitialized): Failed to send
>  software reset: ffffffb9
> asix 1-1:1.0 (unnamed net_device) (uninitialized): Failed to write
>  reg index 0x0000: -71
> asix 1-1:1.0 (unnamed net_device) (uninitialized): Failed to enable
>  software MII access
> asix 1-1:1.0 (unnamed net_device) (uninitialized): Failed to read
>  reg index 0x0000: -71
> asix 1-1:1.0 (unnamed net_device) (uninitialized): Failed to write
>  reg index 0x0000: -71
> asix 1-1:1.0 (unnamed net_device) (uninitialized): Failed to enable
>  software MII access
> asix 1-1:1.0 (unnamed net_device) (uninitialized): Failed to read
>  reg index 0x0000: -71
> ... 
> 
> Signed-off-by: Zhang Run <zhang.run@....com.cn>
> Reviewed-by: Yang Wei <yang.wei9@....com.cn>

Tested-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>

> ---
>  drivers/net/usb/asix_devices.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/asix_devices.c
> b/drivers/net/usb/asix_devices.c
> index b654f05..3d93993 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -739,8 +739,13 @@ static int ax88772_bind(struct usbnet *dev,
> struct usb_interface *intf)
>  	asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode,
> 0);
>  	chipcode &= AX_CHIPCODE_MASK;
>  
> -	(chipcode == AX_AX88772_CHIPCODE) ? ax88772_hw_reset(dev, 0) :
> -					    ax88772a_hw_reset(dev, 0);
> +	ret = (chipcode == AX_AX88772_CHIPCODE) ? ax88772_hw_reset(dev,
> 0) :
> +						  ax88772a_hw_reset(dev
> , 0);
> +
> +	if (ret < 0) {
> +		netdev_dbg(dev->net, "Failed to reset AX88772: %d\n",
> ret);
> +		return ret;
> +	}
>  
>  	/* Read PHYID register *AFTER* the PHY was reset properly */
>  	phyid = asix_get_phyid(dev);