linux-kernel - Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190124165243.lvjeriknze7jie6d@DESKTOP-E1NTVVP.localdomain>
Date:   Thu, 24 Jan 2019 16:52:44 +0000
From:   Brian Starkey <Brian.Starkey@....com>
To:     "Andrew F. Davis" <afd@...com>
CC:     Laura Abbott <labbott@...hat.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Christoph Hellwig <hch@...radead.org>,
        Liam Mark <lmark@...eaurora.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        nd <nd@....com>
Subject: Re: [PATCH] staging: android: ion: Allocate from heap ID directly
 without mask

On Thu, Jan 24, 2019 at 10:12:10AM -0600, Andrew F. Davis wrote:
> On 1/24/19 9:24 AM, Brian Starkey wrote:

[snip]

> > 
> > What do you think about renaming ion_allocation_data.unused to heap_id
> > and adding a flag instead? It's adding cruft to a staging API, but it
> > might soften the transition. The "old way" could get completely
> > removed just before destaging. Just a thought.
> > 
> 
> Sounds confusing, backwards compatibility in staging just doesn't seem
> like the right thing to do.
> 

Well, fair enough. It's going to cause a bit of pain - libion could
probably isolate most Android users. Laura patched that in AOSP last
time around, but I don't know how that went (or how strongly Google
feel about kernel ABI changes).

Thanks,
-Brian